villebro commented on PR #40178: URL: https://github.com/apache/superset/pull/40178#issuecomment-4480030833
@madhushreeag some questions/comments before I post a full review: - do we expect there to be duplicates in the user list? I'm surprised this would be the case, as I assume we have unique indexes in place on the relevant metastore tables. - If the frontend now deduplicates users, do we need the backend change? Rather than override the FAB method, I'd prefer to upstream any critical fixes to FAB so FAB gets the fixes + we don't have override logic in place that may become stale as FAB changes its internals - I'm surprised that the PUT would overflow with a few thousand user ids. If this is the case, we may need to change our request size limits to accommodate for larger roles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
