bito-code-review[bot] commented on PR #40238: URL: https://github.com/apache/superset/pull/40238#issuecomment-4484875883
<!-- Bito Reply --> The PR diff and comments indicate a logic error in the documentation regarding the `DASHBOARD_VIRTUALIZATION` and `DASHBOARD_VIRTUALIZATION_DEFER_DATA` flags. The documentation claims that charts outside the viewport don't fetch data under `DASHBOARD_VIRTUALIZATION`, but in reality, data fetching is controlled by the `DASHBOARD_VIRTUALIZATION_DEFER_DATA` flag, which is off by default. This discrepancy can mislead operators about the performance benefits of virtualization. To resolve this, update the documentation to clarify that virtualization gates rendering, while off-screen query deferral depends on enabling the defer-data flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
