rusackas commented on PR #40012: URL: https://github.com/apache/superset/pull/40012#issuecomment-4488695732
A few small things my bot found: 1) require() in logging.test.ts could perhaps be rewritten using j`est.isolateModules()` or `jest.resetModules()` + `jest.requireActual()` to stay lint-compliant 2) Avatar was correctly converted to use forwardRef, but AvatarGroup in the same file was not — it was only changed from a function declaration to an arrow function. If AvatarGroup is ever used as a Tooltip anchor it will still trigger the findDOMNode deprecation warning. Can you wrap it with forwardRef for consistency? 3) The PR description says jest-fail-on-console was wired in to surface React 19 deprecation warnings as an inventory for follow-up fixes — but the last commit removes it. Does that mean it's all clear/done and we don't need it, or should it stay in place in case of future trouble? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
