valentinvera opened a new pull request, #40278: URL: https://github.com/apache/superset/pull/40278
## Summary This fixes a gap in list views that support bulk tagging. Previously, `ListView` only entered bulk-select mode when there was at least one regular bulk action, such as delete or export. As a result, a user could have the tagging feature enabled but still be unable to select rows for `Add Tag` if the page did not expose another bulk action. Changes: - Allow `ListView` bulk-select mode when bulk tagging is available, even if `bulkActions` is empty. - Show the `Bulk select` button on dashboard, chart, and saved query lists when the tagging feature is enabled. - Reuse the same computed bulk-tag flag for the button and the `ListView` prop. - Add DashboardList permission coverage for a tag-only scenario. ## Impact Users can bulk-select dashboards for tagging without needing unrelated delete/export actions. The generic fix also keeps chart and saved-query tagging behavior consistent. ## Validation - `git diff --check` - Attempted `npm test -- DashboardList.permissions.test.tsx --runInBand`, but the cloned frontend has no `node_modules`; `npm ci` failed because upstream `package.json` and `package-lock.json` are not currently in sync in this checkout, and the local Node/npm versions do not match the repo engine requirement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
