betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL
Lab state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#discussion_r323370029
##########
File path: superset/assets/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -68,6 +69,20 @@ class TabbedSqlEditors extends React.PureComponent {
this.removeAllOtherQueryEditors =
this.removeAllOtherQueryEditors.bind(this);
}
componentDidMount() {
+ // migrate query editor and associated tables state to server
Review comment:
@graceguo-supercat the migration is not atomic. If something fails, it will
be retried later when the user opens SQL Lab again, and the state can co-exist
partially in the backend and partially in `localStorage`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
