hy144328 commented on code in PR #40274:
URL: https://github.com/apache/superset/pull/40274#discussion_r3284480004
##########
pytest.ini:
##########
@@ -18,5 +18,30 @@
testpaths =
tests
python_files = *_test.py test_*.py *_tests.py *viz/utils.py
-addopts = -p no:warnings
+# `-p no:warnings` temporarily disabled in favor of more finely tuned
`filterwarnings`.
+#addopts = -p no:warnings
asyncio_mode = auto
+
+# `ignore` virtually reproduces to `-p no:warnings`.
+# Always print RemovedIn20Warning when SQLALCHEMY_WARN_20=1.
+# Additionally, raise errors for refactored RemovedIn20Warning cases to
prevent regression.
+filterwarnings =
+ ignore
+ always::sqlalchemy.exc.RemovedIn20Warning
Review Comment:
Is it OK to ask for a human to have the last word here?
I have also told Bito: [first
comment](https://github.com/apache/superset/pull/40274#discussion_r3284480004),
[second
comment](https://github.com/apache/superset/pull/40274#discussion_r3270244725).
The linked documentation also clearly has an example where the more specific
rule follows the more general rule.
Furthermore, if Bito were right, `ignore` would have the last word, and no
warning would be printed.
If you execute any of the unit tests locally, you will see that
`RemovedIn20Warning` gets printed which confirms that the latter rule confirms
the earlier rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
