Copilot commented on code in PR #40350: URL: https://github.com/apache/superset/pull/40350#discussion_r3285752346
########## superset/mcp_service/css_template/tool/create_css_template.py: ########## @@ -0,0 +1,99 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.css_template.schemas import ( + CreateCssTemplateRequest, + CreateCssTemplateResponse, +) + +logger = logging.getLogger(__name__) + + +@tool( + tags=["mutate"], + class_permission_name="CssTemplate", + method_permission_name="write", + annotations=ToolAnnotations( + title="Create CSS template", + readOnlyHint=False, + destructiveHint=False, + ), +) +async def create_css_template( + request: CreateCssTemplateRequest, ctx: Context +) -> CreateCssTemplateResponse: + """Create a new CSS template that can be applied to dashboards. + + Use this tool when a user wants to save a CSS stylesheet as a named + template for reuse across multiple dashboards. + + The returned ``id`` can be used when configuring dashboard appearance. + """ + await ctx.info("Creating CSS template: template_name=%r" % (request.template_name,)) Review Comment: This log line exceeds the repo’s configured Ruff line-length (88) and will fail linting (E501). Split the `await ctx.info(...)` call across multiple lines (pattern used in other MCP tools). ########## superset/commands/css/exceptions.py: ########## @@ -25,3 +29,11 @@ class CssTemplateDeleteFailedError(DeleteFailedError): class CssTemplateNotFoundError(CommandException): message = _("CSS template not found.") + + +class CssTemplateCreateFailedError(CreateFailedError): + message = _("CSS template could not be created.") + + +class CssTemplateInvalidError(CommandException): + message = _("CSS template parameters are invalid.") Review Comment: `CssTemplateInvalidError` represents a validation problem and should inherit from `CommandInvalidError` (422) rather than `CommandException` (defaults to 500). This matches other command exception patterns (e.g. `DatasetInvalidError`). ########## superset/mcp_service/css_template/tool/create_css_template.py: ########## @@ -0,0 +1,99 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.css_template.schemas import ( + CreateCssTemplateRequest, + CreateCssTemplateResponse, +) + +logger = logging.getLogger(__name__) + + +@tool( + tags=["mutate"], + class_permission_name="CssTemplate", + method_permission_name="write", + annotations=ToolAnnotations( + title="Create CSS template", + readOnlyHint=False, + destructiveHint=False, + ), +) +async def create_css_template( + request: CreateCssTemplateRequest, ctx: Context +) -> CreateCssTemplateResponse: Review Comment: New MCP tool `create_css_template` is introduced without unit tests. The repo has extensive `tests/unit_tests/mcp_service/**/tool` coverage for similar mutate tools (e.g. create_virtual_dataset), so this should add schema validation tests and tool behavior tests (success + invalid + create-failed + permission denied). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
