rusackas opened a new pull request, #40384:
URL: https://github.com/apache/superset/pull/40384
### SUMMARY
- Deletes 27 `_skip.*` spec files that are permanently excluded from CI via
`excludeSpecPattern: ['**/_skip.*']` in `cypress.config.ts`. These files never
run and exist only as dead code.
- Strips 22 `it.skip()` tests from `editmode.test.ts` — all belong to the
`Color consistency` describe block, permanently skipped because ECharts renders
to canvas and Cypress cannot inspect canvas elements. The 1 active `it('should
add charts')` test is preserved along with the minimal helpers it needs.
- No active tests are removed. No CI behavior changes.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — no UI changes.
### TESTING INSTRUCTIONS
- Confirm `cypress.config.ts` still lists `excludeSpecPattern:
['**/_skip.*']` (no longer needed for the deleted files, but no change required)
- Run the Cypress suite and verify `editmode.test.ts` still executes the
`should add charts` test
- Verify no other spec files reference the deleted `_skip.*` files
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
