sadpandajoe commented on code in PR #40237:
URL: https://github.com/apache/superset/pull/40237#discussion_r3291586112
##########
superset/models/core.py:
##########
@@ -94,6 +94,12 @@
metadata = Model.metadata # pylint: disable=no-member
logger = logging.getLogger(__name__)
+# Per-process SQLAlchemy engine cache (#27897). Key is
+# (database_id, str(sqlalchemy_url), repr(sorted(engine_kwargs.items()))).
+# Populated only when ``nullpool=False`` — pooled engines are the only ones
+# that benefit from process-wide reuse.
+_ENGINE_CACHE: dict[tuple[Any, ...], Engine] = {}
Review Comment:
will editing a Database (password rotation, host change, SSH tunnel
reconfig) or deleting it ever pop the cache here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
