Cloud-Architect-Emma commented on PR #40190: URL: https://github.com/apache/superset/pull/40190#issuecomment-4525034201
Hi @hainenber, added a unit test to `tests/unit_tests/common/test_dataframe_utils.py` that covers: - String-encoded numeric columns (e.g. ClickHouse SUM()) → converted to numeric - Mixed columns with non-numeric values → NOT converted - Non-numeric text columns → NOT converted - Non-metric columns → NOT touched Could you re-review? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
