bito-code-review[bot] commented on code in PR #39301: URL: https://github.com/apache/superset/pull/39301#discussion_r3294566540
########## tests/unit_tests/utils/test_network.py: ########## @@ -0,0 +1,99 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from unittest.mock import patch + +import pytest + +from superset.utils.network import is_safe_host + + [email protected]( + "resolved_ip, expected", + [ + # Public IPs → safe + ("93.184.216.34", True), # example.com Review Comment: <!-- Bito Reply --> The suggestion to change the parametrize argument from a string to a tuple is valid and improves code clarity. The change aligns with Python best practices and ensures better readability and maintainability of the test function. **tests/unit_tests/utils/test_network.py** ``` ("resolved_ip", "expected"), [ # Public IPs → safe ("93.184.216.34", True), # example.com ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
