bito-code-review[bot] commented on code in PR #37458: URL: https://github.com/apache/superset/pull/37458#discussion_r3300067860
########## superset/translations/sl/LC_MESSAGES/messages.po: ########## @@ -12152,8 +12152,16 @@ msgstr "Pošlji" msgid "Subtitle" msgstr "Naslov zavihka" -msgid "Subtotal" -msgstr "Delna vsota" +#, fuzzy +msgid "Subtitle Font Size" +msgstr "Velikost mehurčka" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect translation for Subtitle Font Size</b></div> <div id="fix"> Remove the fuzzy flag and replace the incorrect translation 'Velikost mehurčka' with 'Velikost pisave podnapisa' for the 'Subtitle Font Size' entry. </div> </div> <small><i>Code Review Run #8f544e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh/LC_MESSAGES/messages.po: ########## @@ -12233,9 +12233,17 @@ msgstr "提交" msgid "Subtitle" msgstr "选项卡标题" -msgid "Subtotal" +#, fuzzy +msgid "Subtitle Font Size" +msgstr "气泡尺寸" + +msgid "Subvalue (%(aggfunc)s)" msgstr "" +msgid "Subvalue (%(aggregatorName)s)" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Empty translations for Subvalue</b></div> <div id="fix"> Two new Subvalue translation entries have empty msgstr values, causing English text to display in the Chinese UI until translated. </div> </div> <small><i>Code Review Run #8f544e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fi/LC_MESSAGES/messages.po: ########## @@ -21947,9 +21947,11 @@ msgstr "Alaotsikko" # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs, # de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk] -#, fuzzy -msgid "Subtotal" -msgstr "Välisumma" +msgid "Subvalue (%(aggfunc)s)" +msgstr "" + +msgid "Subvalue (%(aggregatorName)s)" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing Finnish translations for new keys</b></div> <div id="fix"> The Finnish translation "Välisumma" was removed from the "Subtotal" key but should be preserved for the renamed "Subvalue" keys. Other locales like Spanish correctly translate "Subvalue (%(aggfunc)s)" as "Subtotal (%(aggfunc)s)". Apply the same pattern: `msgstr "Välisumma (%(aggfunc)s)"` and `msgstr "Välisumma (%(aggregatorName)s)"`. </div> </div> <small><i>Code Review Run #8f544e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/zh_TW/LC_MESSAGES/messages.po: ########## @@ -12246,9 +12246,17 @@ msgstr "提交" msgid "Subtitle" msgstr "選項卡標題" -msgid "Subtotal" +#, fuzzy Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing translation for Subtotal</b></div> <div id="fix"> Deletion of `msgid "Subtotal"` removes a translation key used by the pivot table feature (`rowSubtotalPosition`, `colSubtotalPosition`). Other locales (e.g., Spanish) translate this as 'Subtotal'. Without this entry, zh_TW users see untranslated text. Restore the line with proper Traditional Chinese translation. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- superset/translations/zh_TW/LC_MESSAGES/messages.po +++ superset/translations/zh_TW/LC_MESSAGES/messages.po @@ -12246,6 +12246,8 @@ msgstr "選項卡標題" msgid "Subtotal" +msgstr "小計" + msgid "Subtitle Font Size" #, fuzzy msgstr "氣泡尺寸" ``` </div> </details> </div> <small><i>Code Review Run #8f544e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fa/LC_MESSAGES/messages.po: ########## @@ -12119,8 +12119,16 @@ msgstr "ارسال" msgid "Subtitle" msgstr "عنوان برگه" -msgid "Subtotal" -msgstr "زیرمجموعه" +#, fuzzy +msgid "Subtitle Font Size" +msgstr "اندازه حباب" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Fuzzy translation quality</b></div> <div id="fix"> The 'Subtitle Font Size' translation 'اندازه حباب' contains the word 'حباب' (bubble) which is clearly incorrect — it should translate to font-related terminology like 'اندازه قلم' or 'اندازه فونت'. Both entries have fuzzy markers indicating unverified translations requiring review. </div> </div> <small><i>Code Review Run #8f544e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/th/LC_MESSAGES/messages.po: ########## @@ -21741,9 +21741,11 @@ msgstr "คำบรรยาย" # Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs, # de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ru, sk, sl, uk] -#, fuzzy -msgid "Subtotal" -msgstr "ผลรวมย่อย" +msgid "Subvalue (%(aggfunc)s)" +msgstr "" + +msgid "Subvalue (%(aggregatorName)s)" +msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CWE-233: Translation Parameter Mismatch</b></div> <div id="fix"> Remove the orphaned msgid "Subvalue (%(aggfunc)s)" entry, as the code references only "Subvalue (%(aggregatorName)s)". (See also: [CWE-233](https://cwe.mitre.org/data/definitions/233.html)) </div> </div> <small><i>Code Review Run #8f544e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/fa/LC_MESSAGES/messages.po: ########## @@ -12119,8 +12119,16 @@ msgstr "ارسال" msgid "Subtitle" msgstr "عنوان برگه" -msgid "Subtotal" -msgstr "زیرمجموعه" +#, fuzzy +msgid "Subtitle Font Size" +msgstr "اندازه حباب" + +msgid "Subvalue (%(aggfunc)s)" +msgstr "زیرمجموعه (%(aggfunc)s)" + +msgid "Subvalue (%(aggregatorName)s)" +msgstr "زیرمجموعه (%(aggregatorName)s)" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Translation semantic error</b></div> <div id="fix"> The Persian translations for 'Subvalue' entries use 'زیرمجموعه' (subset), which incorrectly translates to 'subset' rather than 'subtotal'. German translation correctly uses 'Zwischensumme' (subtotal). The term 'زیرمجموعه' is mathematically distinct from 'subtotal' — it means a portion of a set, not a partial sum in accounting/data aggregation. Users will see misleading 'subset' labels in pivot table subtotal rows instead of proper 'subtotal' labels. </div> </div> <small><i>Code Review Run #8f544e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
