codeant-ai-for-open-source[bot] commented on code in PR #40431:
URL: https://github.com/apache/superset/pull/40431#discussion_r3303093967
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -5714,25 +5284,20 @@ msgstr "Enddatum aus dem Zeitraum ausgeschlossen"
msgid "End date must be after start date"
msgstr "‚Von Datum' kann nicht größer als ‚Bis Datum' sein"
-#, fuzzy
msgid "Ends With"
-msgstr "Kantenbreite"
+msgstr "Endet mit"
#, python-format
msgid "Engine \"%(engine)s\" cannot be configured through parameters."
-msgstr ""
-"Die Engine-Spezifikation \"%(engine)s\" unterstützt keine Konfiguration "
-"über Parameter."
+msgstr "Die Engine-Spezifikation \"%(engine)s\" unterstützt keine
Konfiguration über Parameter."
msgid "Engine Parameters"
msgstr "Engine-Parameter"
-msgid ""
-"Engine spec \"InvalidEngine\" does not support being configured via "
-"individual parameters."
+msgid "Engine spec \"InvalidEngine\" does not support being configured via
individual parameters."
msgstr ""
-"Die Engine-Spezifikation \"%(engine_spec)s\" unterstützt keine "
-"Konfiguration über einzelne Parameter."
+"Die Engine-Spezifikation \"%(engine_spec)s\" unterstützt keine Konfiguration
über einzelne "
+"Parameter."
Review Comment:
**Suggestion:** The German translation introduces a named interpolation
placeholder (`%(engine_spec)s`) even though the source message has no
placeholder at all. This causes a contract mismatch with callers: either users
will see raw placeholder text in UI, or formatting code paths can break if they
try to apply interpolation unexpectedly. Remove the placeholder from the
translation and keep it fully literal to match the source string. [api mismatch]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ⚠️ German database validation error shows raw `%(engine_spec)s`
placeholder.
- ⚠️ Database connection wizard error messaging is confusing for German
users.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Ensure German locale is active by setting `LANGUAGES = {"de": {"flag":
"de", "name":
"German"}}` in `superset_config.py` and switching the UI language to German
in user
settings.
2. Trigger the database validation path that uses the message at
`superset/databases/schemas.py:13-16` by sending an API request with an
engine/driver
combination that resolves to an invalid engine spec (i.e.,
`get_engine_spec(engine,
driver)` returns an object without `build_sqlalchemy_uri` or
`parameters_schema`). This is
the `ValidationError` raised with `_( 'Engine spec "InvalidEngine" does not
support being
configured via individual parameters.' )`.
3. When the validation error is surfaced in the German UI, the translation
from
`superset/translations/de/LC_MESSAGES/messages.po:5298-5301` is used:
- `msgid "Engine spec \"InvalidEngine\" does not support being configured
via
individual parameters."`
- `msgstr "" "Die Engine-Spezifikation \"%(engine_spec)s\" unterstützt
keine
Konfiguration über einzelne " "Parameter."`
4. Because the source message has no interpolation placeholder but the
German translation
introduces `%(engine_spec)s` without any value being passed for
`engine_spec`, the user
sees a broken message containing the raw `%(engine_spec)s` placeholder in
the German UI
instead of a correctly formatted error string.
```
</details>
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=32810a045c92467a81bde1ba789a3083&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=32810a045c92467a81bde1ba789a3083&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/de/LC_MESSAGES/messages.po
**Line:** 5298:5301
**Comment:**
*Api Mismatch: The German translation introduces a named interpolation
placeholder (`%(engine_spec)s`) even though the source message has no
placeholder at all. This causes a contract mismatch with callers: either users
will see raw placeholder text in UI, or formatting code paths can break if they
try to apply interpolation unexpectedly. Remove the placeholder from the
translation and keep it fully literal to match the source string.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=1efed25d9eb7e28fc84fc53ae98f52a56edc4958d258a97d4c0e3c1b78e1b7ef&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40431&comment_hash=1efed25d9eb7e28fc84fc53ae98f52a56edc4958d258a97d4c0e3c1b78e1b7ef&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
