bito-code-review[bot] commented on PR #40471:
URL: https://github.com/apache/superset/pull/40471#issuecomment-4556884586

   <!-- Bito Reply -->
   The PR comment indicates a logic error where the MCP hello page's 
authentication hint is derived from Flask config flags instead of the actual 
runtime auth configuration. This can lead to incorrect instructions for users 
regarding the inclusion of Authorization headers. To resolve this, the 
`auth_enabled` flag should be derived from the effective runtime auth 
configuration (the instantiated provider/factory config auth) rather than just 
from the presence of config flags. This change will ensure the hello page 
accurately reflects the actual authentication state of the running MCP app.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to