aminghadersohi commented on PR #40346: URL: https://github.com/apache/superset/pull/40346#issuecomment-4557440137
Thanks again for the detailed review! Following up on the remaining items: **#4 (test coverage gaps)** — Added in commit `163012b52f`: - `test_list_queries_select_columns_projects_fields` — already existed from a prior pass ✓ - `test_list_queries_invalid_order_column_raises` — already existed ✓ - `test_list_saved_queries_select_columns_projects_fields` — **added** - `test_list_saved_queries_invalid_order_column_raises` — **added** - `test_get_query_info_internal_error` — **added** (InternalError path, generic message) - `test_get_saved_query_info_internal_error` — **added** (InternalError path, generic message) **#4 (security)** — Also fixed `get_query_info` to return a generic error message instead of `str(e)`, matching the `get_saved_query_info` fix from `2c742bb4fa`. **#5 (app.py instruction-text inconsistency)** — Already resolved in a prior commit; both entries now say `(1-based pagination)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
