bito-code-review[bot] commented on code in PR #40475:
URL: https://github.com/apache/superset/pull/40475#discussion_r3321082674
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/utils.ts:
##########
@@ -130,6 +130,9 @@ export const createHandleSave =
if (formInputs.dataset) {
target.datasetId = formInputs.dataset.value;
}
+ if (formInputs.datasourceType) {
+ target.datasourceType = formInputs.datasourceType;
+ }
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>SEMANTIC_DUPLICATION</b></div>
<div id="fix">
The added `datasourceType` assignment (lines 133-135) duplicates existing
logic in `filterTransformer.ts:100-101` and
`customizationTransformer.ts:95-96`. This creates maintenance risk where future
changes to this pattern require updates in three places. Consider extracting a
shared helper function.
</div>
</div>
<small><i>Code Review Run #37e9f4</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
