aminghadersohi commented on code in PR #40473:
URL: https://github.com/apache/superset/pull/40473#discussion_r3329456791
##########
superset/mcp_service/dataset/schemas.py:
##########
@@ -315,13 +334,80 @@ def create(cls, error: str, error_type: str) ->
"DatasetError":
)
+DEFAULT_GET_DATASET_INFO_COLUMNS: List[str] = [
+ "id",
+ "table_name",
+ "schema",
+ "database_name",
+ "database_id",
+ "uuid",
+ "is_virtual",
+ "description",
+ "main_dttm_col",
+ "sql",
+ "url",
+ "columns",
+ "metrics",
+]
+
+DEFAULT_GET_DATASET_INFO_COLUMN_FIELDS: List[str] = [
+ "column_name",
+ "type",
+ "is_dttm",
+]
Review Comment:
Fixed in be1a407188: added
`test_get_dataset_info_default_select_columns_excludes_verbose_fields` which
calls `get_dataset_info` with default args and asserts (a) `params`,
`template_params`, `extra` are absent from the result, and (b) core fields
`id`, `table_name`, `columns`, `metrics` are present. Also added
`test_get_dashboard_info_default_select_columns_excludes_css` with equivalent
coverage for the dashboard side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
