rusackas opened a new pull request, #41178:
URL: https://github.com/apache/superset/pull/41178

   ### SUMMARY
   
   The [PyPI installation 
page](https://superset.apache.org/admin-docs/installation/pypi) had an 
inaccurate claim and some stale/incomplete OS dependencies that could leave 
users stuck.
   
   **Python version claim was wrong.** The page stated that Ubuntu 24.04's 
default Python 3.12 "is not supported by Superset" and walked users through a 
`deadsnakes` PPA + `python3.11` workaround. But `pyproject.toml` declares 
`requires-python = ">=3.10"` with classifiers for 3.10, 3.11, and **3.12** — so 
3.12 is supported and the workaround was unnecessary. The page was also 
internally inconsistent: the macOS section already (correctly) defers to 
`pyproject.toml` for supported versions.
   
   **OS dependencies didn't match the repo's own `Dockerfile`.** Cross-checking 
the apt list against the build deps in `Dockerfile`, a few were missing or 
stale:
   - `python3-venv` — `python3 -m venv` (used later on this same page) fails on 
stock Debian/Ubuntu without it.
   - `pkg-config` — needed to build `mysqlclient`.
   - `libpq-dev` — Postgres dev headers (noted as optional, only for Postgres 
connections).
   - The `yum` block used py2-era names 
(`python-devel`/`python-pip`/`python-wheel`); fixed to `python3-*` (the 
parallel `dnf` block was already correct).
   
   **Cleanup.** Collapsed the three redundant Ubuntu blocks into one (the 
package set is identical across 20.04/22.04/24.04) and dropped the "before 
20.04" block, since those releases are EOL.
   
   Versioned doc snapshots (`admin_docs_versioned_docs`, 
`user_docs_versioned_docs`) are intentionally left untouched, per convention 
for already-released versions.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A — docs text only.
   
   ### TESTING INSTRUCTIONS
   
   Docs-only change. Verify the claims:
   - `grep "requires-python" pyproject.toml` → `>=3.10`, and the classifiers 
list 3.10/3.11/3.12.
   - The added apt packages (`python3-venv`, `pkg-config`, `libpq-dev`) mirror 
the build deps in the repo `Dockerfile`.
   - Render `docs/admin_docs/installation/pypi.mdx` locally and confirm 
formatting.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to