rusackas commented on PR #37712: URL: https://github.com/apache/superset/pull/37712#issuecomment-4770802161
@YousufFFFF the blocker I flagged is still here: `mapXAxisSortToSeriesType` pattern-matches the chosen value into one of five `SortSeriesType` aggregations, so when the user sorts by an actual axis column or metric it returns `undefined` and `xAxisSortSeries` silently falls back to default (Sum) ordering — which is exactly the #34352 case. The substring match is fragile too (`total_summary`→Sum, `customer_name`→Name). I think the sort path needs to carry the chosen column, not a string we reverse-engineer into an enum. Can't land it as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
