amaannawab923 opened a new pull request, #41388: URL: https://github.com/apache/superset/pull/41388
### SUMMARY Changing a metric's **Value Aggregation** on an interactive table and clicking **Update chart** didn't save — it quietly reverted to the previous option. The one workaround people found was to also trigger a sort on the column first and *then* update, which was a big hint about what was going on. The grid's column-state change detection only keyed off column order, sorts and filters, so a standalone aggregation change wasn't captured at all. Triggering a sort changed the detected state and dragged the aggregation along with it — hence the workaround. Including the per-column aggregation in the change signature makes the aggregation change persist on its own. This shares its root cause with the related "Value Aggregation None doesn't persist" fix — same signature gap, different symptom. ### TESTING INSTRUCTIONS 1. Create an interactive table using a dataset with a numeric metric (e.g. `SUM(sales)`). 2. From the metric's **Value Aggregation**, pick a different option and click **Update chart** (without sorting first). 3. The selected aggregation should be saved and survive a reload. Unit tests added covering that an aggregation change alters the capture signature without any sort/order/filter change. ### ADDITIONAL INFORMATION - [x] Changes UI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
