rusackas commented on code in PR #39461:
URL: https://github.com/apache/superset/pull/39461#discussion_r3478099285
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -810,12 +768,7 @@ function OwnersSelector({
.filter(item => item.extra.active)
.map(item => ({
value: item.value as number,
- label: OwnerSelectLabel({
- name: item.text as string,
- email: item.extra?.email as string | undefined,
- }),
- [OWNER_TEXT_LABEL_PROP]: item.text as string,
- [OWNER_EMAIL_PROP]: (item.extra?.email as string) ?? '',
+ label: item.text as string,
})),
Review Comment:
Good catch - restored `OwnerSelectLabel` + the two extra-field props and
`optionFilterProps={OWNER_OPTION_FILTER_PROPS}` on the select, plus the same in
the owner-init mapping, so email shows under the name and email search works
again. Thanks!
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx:
##########
@@ -363,24 +338,9 @@ const FlexRowContainer = styled.div`
`;
const StyledTableTabs = styled(Tabs)`
- flex: 1;
- min-height: 0;
- display: flex;
- flex-direction: column;
-
+ overflow: visible;
.ant-tabs-content-holder {
- flex: 1;
- min-height: 0;
- overflow: auto;
- padding-top: ${({ theme }) => theme.paddingMD}px;
- }
-
- .ant-tabs-content {
- height: 100%;
- }
-
- .ant-tabs-tabpane-active {
- height: 100%;
+ overflow: visible;
}
`;
Review Comment:
Restored the flex chain - `flex: 1; min-height: 0` on
`DatasourceContainer`/`StyledTableTabs` and `overflow: auto` back on
`.ant-tabs-content-holder` so the tabs scroll inside the modal again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
