bito-code-review[bot] commented on code in PR #41456:
URL: https://github.com/apache/superset/pull/41456#discussion_r3483956156
##########
tests/unit_tests/semantic_layers/mapper_test.py:
##########
@@ -1003,6 +1004,246 @@ def
test_map_query_object_with_time_offsets(mock_datasource: MagicMock) -> None:
}
+def _make_grain_variant_datasource(
+ mocker: MockerFixture,
+ granularity_dim_grain: Grain | None,
+ extra_dim_grain: Grain | None = None,
+) -> MagicMock:
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Unused parameter in helper</b></div>
<div id="fix">
Parameter `extra_dim_grain` is declared but never used in
`_make_grain_variant_datasource`. This dead parameter creates maintenance
confusion about its intended purpose. Consider removing it to keep the helper's
contract clean.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
def _make_grain_variant_datasource(
mocker: MockerFixture,
granularity_dim_grain: Grain | None,
) -> MagicMock:
````
</div>
</details>
</div>
<small><i>Code Review Run #d33c86</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
