massucattoj commented on PR #40000: URL: https://github.com/apache/superset/pull/40000#issuecomment-4813797390
Update: fixed the pre-filter not applying at runtime (reported by @DamianPendrak) the time grain plugins read formData.time_grains, but ChartProps camelCases every formData key before it reaches a chart plugin (convertKeysToCamelCase, ChartProps.ts:195). So the runtime key is timeGrains, and formData.time_grains was always undefined. This is the same snake→camel boundary that turns native_filter_id into nativeFilterId, sort_metric into sortMetric, etc. the allowlist read was simply on the wrong side of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
