rusackas opened a new pull request, #41465: URL: https://github.com/apache/superset/pull/41465
### SUMMARY `build_translation_index.py` calls `polib.pofile()` on every language catalog with no error handling, so a single malformed `.po` (e.g. an unescaped quote) raises and aborts the entire index build. That blocks the AI translation backfill for *every* language, not just the broken one. This skips an unparseable catalog with a loud `WARNING` and continues, matching the resilience already present in `check_translation_regression.py` (which warns-and-skips catalogs that won't compile). The corrupt file still needs fixing separately, but it no longer takes the whole index down with it. (Surfaced while running the backfill tooling: `ro/LC_MESSAGES/messages.po` currently fails to parse, which is what exposed this. The `ro` corruption itself is fixed in a separate PR.) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A (developer tooling) ### TESTING INSTRUCTIONS With a malformed catalog present (e.g. an unescaped `"` in any `messages.po`): ```bash python scripts/translations/build_translation_index.py ``` Before: traceback, no index written. After: `WARNING: skipping <lang> …` and the index is written for all parseable languages. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
