bito-code-review[bot] commented on code in PR #41470:
URL: https://github.com/apache/superset/pull/41470#discussion_r3484780514
##########
superset-frontend/src/dashboard/components/DeleteComponentButton.tsx:
##########
@@ -18,6 +18,7 @@
*/
import { MouseEventHandler, FC } from 'react';
+import { t } from '@apache-superset/core/translation';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Test assertion hardcoded 'delete'</b></div>
<div id="fix">
The new `label={t('Delete component')}` prop sets `aria-label` on the button
(IconButton.tsx:46), but existing tests in Divider.test.tsx (line 67) and
Header.test.tsx (lines 140, 148) assert `aria-label='delete'`. These 3 test
assertions will fail after this change. [6516] requires translation for
user-facing text, so the new label is correct — tests need updating to match.
</div>
</div>
<small><i>Code Review Run #0b6212</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
