john-bodley commented on a change in pull request #8371: [migration] make names
non-nullable
URL:
https://github.com/apache/incubator-superset/pull/8371#discussion_r334244507
##########
File path: tests/druid_tests.py
##########
@@ -125,6 +125,13 @@ def get_cluster(self, PyDruid):
.first()
)
if cluster:
+ for datasource in (
+ db.session.query(DruidDatasource)
+ .filter_by(cluster_name="test_cluster")
Review comment:
Does the `cluster` object have the `cluster_name` attribute? That may be a
little cleaner/less error prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
