rusackas commented on PR #35867: URL: https://github.com/apache/superset/pull/35867#issuecomment-4827851086
Thanks for the rebase and the splice rework, @CoderSxy - the move-vs-swap logic and the bounds checks look right. One thing still seems off though: the reordered array doesn't cleanly make it back to `onChange`. `DndFilterSelect` only calls `setValues` (no `onChange`), and the metric / `AdhocFilterControl` paths commit via `onDropLabel`, which closes over the pre-drag `values`... so the UI order looks right but the committed array is the stale one. I think dragging a metric and reloading would revert the order. Mind routing the freshly reordered copy through `onChange`? A small test asserting the committed order would pin it down. `optionSelector.reorder` could also use the same bounds guard the others got, since `DndColumnSelect` goes straight through it. Holler if you want a hand. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
