michael-s-molina commented on PR #41199: URL: https://github.com/apache/superset/pull/41199#issuecomment-4833927282
Hi @jesperct and @rusackas, I noticed the fix currently assumes ANSI double-quote identifiers, but—as @jesperct mentioned in the PR description—other dialects (e.g., MySQL’s backticks) use different quoting. I don't view this requirement as a follow-up but as something that might completely change where this fix is implemented. To avoid potential reversions, could we incorporate dialect awareness in a quick follow-up PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
