rusackas commented on PR #41135: URL: https://github.com/apache/superset/pull/41135#issuecomment-4835642922
Thanks for the careful reviews — addressed in d684a4e. **Re: @EnxDev's should-fix (`white-space: pre` also preserves newlines).** Good catch, and you're right that there's no pure-CSS value that keeps intra-line spaces while collapsing newlines. Rather than add a Playwright test asserting single-line behavior (which `pre` doesn't actually guarantee for newline-containing values), I made the trade-off explicit in the comment: an embedded newline renders on multiple lines and is clipped by the fixed row height, and truncating such values to the visible row is acceptable here. The whitespace-sensitive cases this fixes (option symbols and similar) are single-line by nature. **Re: @bito-code-review's overflow flag.** Even though `.ag-cell` already clips, I added `overflow: hidden; text-overflow: ellipsis;` to `.ag-cell-value` so an over-long single-line value truncates with an ellipsis rather than risking overflow — matches the truncation pattern referenced and costs nothing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
