Aitema-gmbh commented on PR #39235:
URL: https://github.com/apache/superset/pull/39235#issuecomment-4842095085
@rusackas thanks — both points addressed:
1. **PR description** rewritten to match what actually ships (unitless
line-heights + token/`em` font sizes), dropped the stale mentions of `html {
font-size: 100% }` / rem conversion / UserInfo·Modal·DatabaseModal that weren't
in the diff.
2. **CustomizationsBadge / DateFilterLabel** — converted the remaining
`${theme.fontSizeSM}px` / `${theme.fontSize}px` font sizes to token-driven `em`
(`${theme.fontSizeSM / theme.fontSize}em`, and `1em` for the base one), so they
scale with the browser text-size setting instead of staying pinned. So that
thread is resolved by code rather than a "won't fix".
Rebased onto current master and squashed to a single commit (this also drops
the stray `TextControl` validation code for good).
Same CI note as on #39233: the only red checks are `sharded-jest-tests
(5)`/`(7)`, which are a **pre-existing master failure** (`SavedQueryList "+
Query"` router test and `TablePreview` metadata/CREATE VIEW) — reproducible on
a clean `master` checkout and identical on unrelated PRs; this diff doesn't
touch those areas. Everything relevant (pre-commit, lint, frontend-build, the
date-filter/menu tests) is green.
Happy to squash-merge whenever you're ready — thanks for the thorough review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
