Freeman-89 opened a new pull request, #41580: URL: https://github.com/apache/superset/pull/41580
âŚn combined endpoint Replace the 10-element tuple from _parse_filters() with a _Filters dataclass, add keyword-only params to build_dataset_query(), and fix the certified filter to match the existing DatasetCertifiedFilter pattern. Add unit tests for the four restored filters. <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY The combined `/api/v1/datasource/` endpoint was missing support for schema, owner, certified, and changed_by filters that work in `/api/v1/dataset/`. `_parse_filters()` parsed these values but they were silently dropped â the old 10-element return tuple made it easy to forget new fields. Replaced the flat tuple with a typed `_Filters` dataclass, made `build_dataset_query()` params keyword-only, and aligned the certified filter check with the existing `DatasetCertifiedFilter` pattern. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A â backend-only change, no UI. ### TESTING INSTRUCTIONS Run `pytest tests/unit_tests/commands/datasource/list_test.py -v` â all 11 tests should pass. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
