betodealmeida commented on code in PR #41611:
URL: https://github.com/apache/superset/pull/41611#discussion_r3509360363
##########
superset/daos/semantic_layer.py:
##########
@@ -201,6 +201,29 @@ def validate_update_uniqueness(
for c in candidates
)
+ @classmethod
+ def find_accessible(cls) -> list[SemanticView]:
+ """Return all views the current user can access, filtered at SQL level.
+
+ Mirrors the permission filter in
``DatasourceDAO.build_semantic_view_query``
+ to avoid per-row Python-level access checks when listing all views.
+ """
+ from sqlalchemy import or_
+
+ query = db.session.query(SemanticView)
+ if not security_manager.can_access_all_datasources():
+ perms = security_manager.user_view_menu_names("datasource_access")
+ query = query.outerjoin(
Review Comment:
I don't think we need an `outerjoin` here, a `join` should suffice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
