rusackas opened a new pull request, #41648:
URL: https://github.com/apache/superset/pull/41648

   ### SUMMARY
   
   The main `Dockerfile` compiled backend translations with a bare `pybabel 
compile`, which **omits `#, fuzzy` entries** — so fuzzy (machine-generated and 
other draft) translations fell back to English on the backend. This is 
inconsistent with every other translation build path in the repo:
   
   - the **frontend** build (`superset-frontend/scripts/po2json.sh`) runs 
`po2json --fuzzy`, which *includes* fuzzy entries;
   - **`flask fab babel-compile`** — used by the RELEASING images 
(`RELEASING/Dockerfile.from_*_tarball`) and 
`scripts/translations/generate_mo_files.sh` — runs `pybabel compile -f` 
internally (see `flask_appbuilder/cli.py`).
   
   So the production image was the *only* path dropping fuzzy translations. 
This PR adds `--use-fuzzy` to the Dockerfile's `pybabel compile`, making the 
backend serve fuzzy translations consistently with the frontend and the other 
backend build paths.
   
   **Motivation:** we're running an AI-assisted backfill across the language 
catalogs (fuzzy-marked, pending native-speaker review — see the 
de/lv/fi/es/sk/th/uk/cs PRs). With this change, those draft translations (and 
any other `#, fuzzy` entries) are shown in the UI on both frontend and backend 
rather than falling back to English while awaiting review. `#, fuzzy` remains 
the "needs review" marker; reviewers de-fuzz to confirm.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Backend-compiled catalogs (`BUILD_TRANSLATIONS=true`):
   - **Before:** `#, fuzzy` entries excluded → English fallback in 
server-rendered strings.
   - **After:** `#, fuzzy` entries included → translated string served 
(matching the frontend).
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   # fuzzy entry is included with --use-fuzzy, excluded without it
   pybabel compile --use-fuzzy --statistics -d superset/translations
   ```
   Build the image with `--build-arg BUILD_TRANSLATIONS=true` and confirm a `#, 
fuzzy` backend string renders translated rather than in English.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [x] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to