bito-code-review[bot] commented on code in PR #41649: URL: https://github.com/apache/superset/pull/41649#discussion_r3509772394
########## superset/translations/ru/LC_MESSAGES/messages.po: ########## @@ -17773,12 +18210,19 @@ msgid "std" msgstr "стандартное отклонение" # Не переводить +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs, +# de, es, fa, ja, lv, mi, nl, pt_BR, ro, sk, sl, sr, sr_Latn, tr, uk] +#, fuzzy msgid "step-after" -msgstr "" +msgstr "шаг-после" # Не переводить +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs, +# de, es, fa, fr, ja, lv, mi, nl, pl, pt_BR, ro, sk, sl, sr, sr_Latn, tr, uk, +# zh, zh_TW] +#, fuzzy msgid "step-before" -msgstr "" +msgstr "шаг-до" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CWE-20: Do-not-translate comment ignored by backfill script</b></div> <div id="fix"> Identical to the `step-after` finding: `step-before` also carries `# Не переводить` and was filled with `шаг-до` by backfill_po.py despite the maintainer's stated intent. Both entries are for ECharts axis tick-step labels. (See also: [CWE-20](https://cwe.mitre.org/data/definitions/20.html)) </div> </div> <small><i>Code Review Run #79cef5</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/ru/LC_MESSAGES/messages.po: ########## @@ -17823,8 +18270,11 @@ msgstr "К цвету текста" msgid "textarea" msgstr "текстовая область" +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr, +# sr_Latn] +#, fuzzy msgid "the Handlebars chart documentation" -msgstr "" +msgstr "документацию по графикам Handlebars" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Do-not-translate comment ignored by backfill script</b></div> <div id="fix"> The `# Не переводить` comment precedes this entry. The backfill script filled `msgstr` despite this comment. The fuzzy flag was added. Restore the empty msgstr. </div> </div> <small><i>Code Review Run #79cef5</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/ru/LC_MESSAGES/messages.po: ########## @@ -17773,12 +18210,19 @@ msgid "std" msgstr "стандартное отклонение" # Не переводить +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs, +# de, es, fa, ja, lv, mi, nl, pt_BR, ro, sk, sl, sr, sr_Latn, tr, uk] +#, fuzzy msgid "step-after" -msgstr "" +msgstr "шаг-после" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CWE-20: Do-not-translate comment ignored by backfill script</b></div> <div id="fix"> The `step-after` entry carries a `# Не переводить` comment indicating the maintainer intended it to remain untranslated (preserving the English term for chart-axis tick labels). `backfill_po.py` fills every empty msgstr without checking for this comment, so the AI-generated `шаг-после` was written despite the stated intent. The `#, fuzzy` flag marks it for review but does not undo the override. Either remove the translation string or add a guard in `backfill_po.py` to skip `# Не переводить` entries. (See also: [CWE-20](https://cwe.mitre.org/data/definitions/20.html)) </div> </div> <small><i>Code Review Run #79cef5</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset/translations/ru/LC_MESSAGES/messages.po: ########## @@ -17914,14 +18364,20 @@ msgid "year" msgstr "год" # Не переводить +# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja, +# lv, sk, sr, sr_Latn, tr, uk] +#, fuzzy msgid "your-project-1234-a1" -msgstr "" +msgstr "ваш-проект-1234-a1" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Do-not-translate comment ignored by backfill script</b></div> <div id="fix"> The `# Не переводить` comment precedes this entry. The backfill script filled msgstr despite this comment, translating the example project ID to `ваш-проект-1234-a1`. Restore the empty msgstr. </div> </div> <small><i>Code Review Run #79cef5</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
