rusackas opened a new pull request, #41652:
URL: https://github.com/apache/superset/pull/41652

   ### SUMMARY
   
   Follow-up cleanup for the AI backfill sweep. The backfill filled some 
entries that must stay **literal / identical to the source** — the same tokens 
a human translator had marked `# Не переводить` ("do not translate") in the 
`ru` catalog:
   
   - **`bolt`** — an icon name (`ControlHeader.tsx` → `label={t('bolt')}` 
renders the ⚡ icon); a translated value breaks the icon lookup.
   - **`step-after` / `step-before`** — d3 line-interpolation enum values.
   - **`error_message`** — an API field name; plus SQL keywords, code constants 
(`TEMPORAL_RANGE`, `EMAIL_REPORTS_CTA`), formats/proper nouns, and example 
placeholders.
   
   CodeAnt flagged several of these on the Russian PR (#41649). This reverts 
the machine-translated entries back to untranslated (so they fall back to the 
source token) in the three **merged** catalogs that contained them:
   
   | Catalog | Reverted |
   |---|---|
   | `es` | 3 |
   | `fi` | 21 |
   | `th` | 21 |
   
   `ru` is fixed in its still-open PR (#41649); de/lv/sk/uk/cs had none (those 
tokens were already human-translated or weren't in their untranslated sets). 
Going forward, `backfill_po.py` skips these via a `DO_NOT_TRANSLATE` set and 
honors do-not-translate translator comments (#41651).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Backend/frontend: e.g. the ⚡ control icon renders correctly again (was 
looking up a translated icon name).
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   # confirm the tokens are untranslated (empty msgstr) in the three catalogs
   grep -A2 '^msgid "bolt"$' superset/translations/th/LC_MESSAGES/messages.po
   ```
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [x] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to