bito-code-review[bot] commented on code in PR #40130: URL: https://github.com/apache/superset/pull/40130#discussion_r3510301805
########## superset/translations/it/LC_MESSAGES/messages.po: ########## @@ -4602,6 +4602,9 @@ msgstr "La tua query non può essere salvata" msgid "Dataset could not be duplicated." msgstr "La tua query non può essere salvata" +msgid "Dataset could not be restored." +msgstr "" Review Comment: <!-- Bito Reply --> The suggestion to provide an Italian translation for the new error message is appropriate. While it is common for untranslated strings to fall back to English, providing a localized translation ensures a consistent user experience for Italian-speaking users, matching the established pattern in the file. **superset/translations/it/LC_MESSAGES/messages.po** ``` msgid "Dataset could not be restored." msgstr "Il dataset non può essere ripristinato." ``` ########## superset/translations/fa/LC_MESSAGES/messages.po: ########## @@ -4634,6 +4634,9 @@ msgstr "گزارش نمیتواند ایجاد شود." msgid "Dataset could not be duplicated." msgstr "مجموعه داده نمیتواند تکرار شود." +msgid "Dataset could not be restored." +msgstr "" Review Comment: <!-- Bito Reply --> The suggestion to provide a Persian translation for the newly added message is appropriate. While it is true that catalogs may carry new message IDs untranslated until a translator fills them in, providing a translation for consistency with similar existing error messages in the same file improves the user experience for Persian-speaking users. Applying this suggestion ensures that the new error message is localized rather than falling back to English. **superset/translations/fa/LC_MESSAGES/messages.po** ``` +msgid "Dataset could not be restored." +msgstr "مجموعه داده نمیتواند بازیابی شود." ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
