bito-code-review[bot] commented on code in PR #40129:
URL: https://github.com/apache/superset/pull/40129#discussion_r3510306628
##########
superset/translations/ru/LC_MESSAGES/messages.po:
##########
@@ -3060,6 +3060,9 @@ msgstr "Изменения диаграммы"
msgid "Chart could not be created."
msgstr "Не удалось создать диаграмму"
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The suggestion is appropriate because it provides a Russian translation for
the previously empty `msgstr` field. Filling this entry ensures that
Russian-speaking users see a localized error message instead of the raw English
source text when a chart restoration fails, which improves the user experience.
**superset/translations/ru/LC_MESSAGES/messages.po**
```
msgid "Chart could not be restored."
-msgstr ""
+msgstr "Не удалось восстановить диаграмму."
```
##########
superset/translations/it/LC_MESSAGES/messages.po:
##########
@@ -2999,6 +2999,9 @@ msgstr "Ultima Modifica"
msgid "Chart could not be created."
msgstr "La tua query non può essere salvata"
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The suggestion to complete the Italian translation for the new message ID is
appropriate. In the context of localization files, leaving `msgstr` empty for
new strings is standard practice, as it allows the system to fall back to the
source English text until a translator provides the localized version.
However, if the goal is to ensure the Italian locale is fully supported
immediately, providing the translation is a valid improvement. The suggestion
is locally correct and improves the user experience for Italian-speaking users
by avoiding untranslated English text.
**superset/translations/it/LC_MESSAGES/messages.po**
```
msgid "Chart could not be updated."
-msgstr "La tua query non può essere salvata"
+msgstr "Il grafico non può essere aggiornato"
```
##########
superset/translations/nl/LC_MESSAGES/messages.po:
##########
@@ -3118,6 +3118,9 @@ msgstr "Veranderingen in de grafiek"
msgid "Chart could not be created."
msgstr "Grafiek kon niet worden aangemaakt."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The suggestion is appropriate for maintaining consistency in the translation
catalog. While it is true that untranslated strings fall back to the source
text, providing a translation ensures a consistent user experience in the
target language, matching the established pattern for other error messages in
the file.
**superset/translations/nl/LC_MESSAGES/messages.po**
```
3121: +msgid "Chart could not be restored."
3122: +msgstr "De grafiek kon niet worden teruggezet."
```
##########
superset/translations/fa/LC_MESSAGES/messages.po:
##########
@@ -3065,6 +3065,9 @@ msgstr "تغییرات نمودار"
msgid "Chart could not be created."
msgstr "نمودار نتوانسته ایجاد شود."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to add a Persian translation is technically
correct in the context of improving user experience, but the project's
established practice for newly-extracted strings in translation catalogs is to
leave the `msgstr` empty. This allows the system to fall back to the source
text until a translator provides a localized version. Given this convention,
declining the suggestion is appropriate.
**superset/translations/fa/LC_MESSAGES/messages.po**
```
+msgid "Chart could not be restored."
+msgstr ""
```
##########
superset/translations/pt/LC_MESSAGES/messages.po:
##########
@@ -3045,6 +3045,9 @@ msgstr "Modificado pela última vez"
msgid "Chart could not be created."
msgstr "Não foi possível gravar a sua query"
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The suggestion is appropriate to apply. Providing a translation for the
error message ensures that Portuguese-speaking users receive clear feedback
instead of an empty string or English text when a chart fails to restore.
**superset/translations/pt/LC_MESSAGES/messages.po**
```
msgid "Chart could not be restored."
-msgstr ""
+msgstr "Não foi possível restaurar o gráfico."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
