bito-code-review[bot] commented on code in PR #24444:
URL: https://github.com/apache/superset/pull/24444#discussion_r3485975401
##########
superset-frontend/packages/superset-ui-core/src/number-format/index.ts:
##########
@@ -35,3 +35,4 @@ export { default as createMemoryFormatter } from
'./factories/createMemoryFormat
export { default as createSiAtMostNDigitFormatter } from
'./factories/createSiAtMostNDigitFormatter';
export { default as createSmartNumberFormatter } from
'./factories/createSmartNumberFormatter';
export { default as getSmallNumberFormatter } from './getSmallNumberFormatter';
+export { default as createLengthFormatter } from
'./factories/createLengthFormatter';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing export in index test</b></div>
<div id="fix">
The `index.test.ts` file verifies all exported symbols are defined, but
`createLengthFormatter` is missing from both the import list (line 20-31) and
the verification array (line 35-46). Other factory functions like
`createD3NumberFormatter`, `createDurationFormatter`, `createMemoryFormatter`,
and `createSiAtMostNDigitFormatter` are all tested. Adding this export to the
index test ensures the exported symbol is verified at module load time.
</div>
</div>
<small><i>Code Review Run #397e22</i></small>
</div><div>
<div id="suggestion">
<div id="issue"><b>Missing unit tests for factory</b></div>
<div id="fix">
The `createLengthFormatter` factory lacks unit tests. Other formatter
factories in this module (createD3NumberFormatter, createDurationFormatter,
createMemoryFormatter) all have dedicated test files, but no test exists for
createLengthFormatter. Add tests covering all convertType options and the
default fallback behavior to match established patterns.
</div>
</div>
<small><i>Code Review Run #560f72</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
