bito-code-review[bot] commented on code in PR #41786: URL: https://github.com/apache/superset/pull/41786#discussion_r3527052725
########## docs/yarn.lock: ########## @@ -16073,10 +16073,10 @@ webpack-virtual-modules@^0.6.2: resolved "https://registry.npmjs.org/webpack-virtual-modules/-/webpack-virtual-modules-0.6.2.tgz"; integrity sha512-66/V2i5hQanC51vBQKPH4aI8NMAcBW59FVBs+rC7eGHupMyfn34q7rZIE+ETlJ+XTevqfUhVVBgSUNSW2flEUQ== -webpack@^5.108.0, webpack@^5.88.1, webpack@^5.95.0: - version "5.108.0" - resolved "https://registry.yarnpkg.com/webpack/-/webpack-5.108.0.tgz#f8bb9b554f25374e8dfa3e1b137b0791a56d7614"; - integrity sha512-Ln1JuYGPRTXcHECapSFSvACtHmWEN5sQqFJeLLGQ0057S7qzT2eXUz0MZUedtmIrNy3nJgnITSubIYKGED9jSQ== +webpack@^5.108.1, webpack@^5.88.1, webpack@^5.95.0: + version "5.108.1" + resolved "https://registry.yarnpkg.com/webpack/-/webpack-5.108.1.tgz#cd5856f9a88e55f344d64a6623c09bf34446cc9d"; + integrity sha512-UUCihHQK3O7483Woa0SulNLDeAiOhHI2PN2PAPU4fVWJqbzhv04EJ8FaWtB9WWh3i8fRt28543U7VfuJTOrpgQ== Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Lock file manual edit violation</b></div> <div id="fix"> Lock files must be regenerated through package manager commands, not manually edited. The version constraint in package.json is correctly set to `^5.108.1`, but yarn.lock should be regenerated with `yarn install` to ensure integrity hashes are correctly calculated and dependency resolution follows yarn's algorithm. </div> </div> <small><i>Code Review Run #073258</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
