bito-code-review[bot] commented on PR #41798:
URL: https://github.com/apache/superset/pull/41798#issuecomment-4892921079
<!-- Bito Reply -->
The flagged issue is correct. The current warning message suggests that
users can "Refine your search" to find missing tables, but the `TableSelector`
component performs client-side filtering on a truncated list, meaning searching
cannot reveal tables that were not initially fetched.
To resolve this, the message should be updated to guide users toward actions
that trigger a new fetch, such as changing the schema or catalog, or refreshing
the data.
Here is a suggested update for the warning message in
`superset-frontend/src/components/TableSelector/index.tsx`:
```tsx
<Alert
type="warning"
showIcon
message={t(
'Some tables are not shown. Try changing the schema or catalog
to find the table you need.',
)}
/>
```
I have checked the PR and there are no other review comments to address.
Would you like me to proceed with any other changes?
**superset-frontend/src/components/TableSelector/index.tsx**
```
<Alert
type="warning"
showIcon
message={t(
'Some tables are not shown. Try changing the schema or catalog
to find the table you need.',
)}
/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
