rusackas opened a new pull request, #41840: URL: https://github.com/apache/superset/pull/41840
### SUMMARY Test-only PR that proves #35087 is fixed on master, and closes it. The issue reported `Unexpected error: TypeError: Do not know how to serialize a BigInt` when clicking "Add or edit filters" on a dashboard where a chart had queried a BigInt column. The crash came from `JSON.stringify(charts)` in a `useMemo` dependency array in `FiltersConfigForm`, evaluated on every render of the filters config modal — chart data responses containing integers beyond `Number.MAX_SAFE_INTEGER` are parsed into native `BigInt` values by `parseResponse` (`parseMethod: 'json-bigint'`), and `JSON.stringify` throws on any `BigInt`. That stringify call was fixed by #34539 (merged Aug 2025), which serializes only the chart ids. However, #34539's regression test only covered opening the modal onto an existing filter configuration (`createNewOnOpen: false`), while the issue's repro is the fresh "Add or edit filters" flow that auto-creates a new filter. This PR adds a test for that exact path and strengthens the shared fixture with a value above `Number.MAX_SAFE_INTEGER` (`9007199254740993n`), mirroring what `parseResponse` actually produces for large integer columns. The new test passes on master, confirming the reported path no longer throws. No production code changes. closes #35087 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A (test-only change) ### TESTING INSTRUCTIONS ```bash cd superset-frontend npm run test -- src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.test.tsx --maxWorkers=2 ``` The new test is `creates a new filter when a chart contains BigInt values`. To see it fail as it would have before the fix, revert the #34539 change in `FiltersConfigForm.tsx` (restore `JSON.stringify(charts)` in the `initiallyExcludedCharts` dependency array) and re-run — the render throws `TypeError: Do not know how to serialize a BigInt`. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> - [x] Has associated issue: closes #35087 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
