codeant-ai-for-open-source[bot] commented on code in PR #41472: URL: https://github.com/apache/superset/pull/41472#discussion_r3532839108
########## superset/mcp_service/chart/schemas.py: ########## @@ -2695,3 +2695,32 @@ class ChartFiltersInfo(BaseModel): # Rebuild ChartInfo so Pydantic can resolve the ChartFiltersInfo forward reference. ChartInfo.model_rebuild() + + +class DeleteChartRequest(BaseModel): + """Request schema for delete_chart.""" + + identifier: int | str = Field( + ..., + description=( + "Chart identifier - numeric ID or UUID string (charts have no slug)." + ), + ) Review Comment: **Suggestion:** Update this request identifier type to use UUID-only input instead of accepting integer IDs, so new public API paths avoid relying on auto-increment primary keys. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> This is a newly added public request schema that accepts an integer ID, which conflicts with the UUID-first rule for new APIs. The code explicitly allows numeric IDs instead of requiring UUIDs. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3b883ab9010a4b279fa3fa736c964e68&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3b883ab9010a4b279fa3fa736c964e68&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/mcp_service/chart/schemas.py **Line:** 2703:2708 **Comment:** *Custom Rule: Update this request identifier type to use UUID-only input instead of accepting integer IDs, so new public API paths avoid relying on auto-increment primary keys. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41472&comment_hash=b8bd684c96093eb111254492f0d3715b922fa98d116eabf465daa5a16163ab24&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41472&comment_hash=b8bd684c96093eb111254492f0d3715b922fa98d116eabf465daa5a16163ab24&reaction=dislike'>👎</a> ########## superset/mcp_service/chart/schemas.py: ########## @@ -2695,3 +2695,32 @@ class ChartFiltersInfo(BaseModel): # Rebuild ChartInfo so Pydantic can resolve the ChartFiltersInfo forward reference. ChartInfo.model_rebuild() + + +class DeleteChartRequest(BaseModel): + """Request schema for delete_chart.""" + + identifier: int | str = Field( + ..., + description=( + "Chart identifier - numeric ID or UUID string (charts have no slug)." + ), + ) + + +class DeleteChartResponse(BaseModel): + """Result of a delete_chart operation.""" + + success: bool = Field(description="Whether the chart was deleted") + deleted_id: int | None = Field(None, description="ID of the deleted chart") Review Comment: **Suggestion:** Replace the integer deleted resource identifier field with a UUID-based field to keep new response contracts aligned with UUID-first primary key guidance. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> This new response schema exposes an integer chart identifier in a public API contract. That is contrary to the UUID-first guidance for new models and public APIs, so the suggestion identifies a real rule violation. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ee8292414ae6440c8ab1503a093c5c99&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ee8292414ae6440c8ab1503a093c5c99&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/mcp_service/chart/schemas.py **Line:** 2715:2715 **Comment:** *Custom Rule: Replace the integer deleted resource identifier field with a UUID-based field to keep new response contracts aligned with UUID-first primary key guidance. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41472&comment_hash=4a3e2e7f925bb0774c1863e6977eb17148cf12506a31ac5d58e523342cfc0d74&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41472&comment_hash=4a3e2e7f925bb0774c1863e6977eb17148cf12506a31ac5d58e523342cfc0d74&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
