codeant-ai-for-open-source[bot] commented on code in PR #41031:
URL: https://github.com/apache/superset/pull/41031#discussion_r3534303270
##########
superset-frontend/src/components/GridTable/index.tsx:
##########
@@ -138,18 +139,20 @@ export function GridTable<RecordType extends object>({
[columnReorderable, enableActions, sortable],
);
- const rowHeight = theme.sizeUnit * (size === GridSize.Middle ? 9 : 7);
+ const defaultRowHeight = theme.sizeUnit * (size === GridSize.Middle ? 9 : 7);
+ const rowHeight = themeOverrides?.rowHeight ?? defaultRowHeight;
+ const headerHeight = themeOverrides?.headerHeight ?? rowHeight;
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag `headerHeight` defaulting to `rowHeight` in GridTable; row and
header height are intentionally tied together, and theme row-height tokens are
expected to drive both.
**Applied to:**
- `superset-frontend/src/components/GridTable/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
