bito-code-review[bot] commented on code in PR #38535:
URL: https://github.com/apache/superset/pull/38535#discussion_r3539682770
##########
superset-frontend/src/utils/downloadAsImage.tsx:
##########
@@ -25,6 +25,8 @@ import { addWarningToast } from
'src/components/MessageToasts/actions';
import type { AgGridContainerElement } from '@superset-ui/core/components';
const IMAGE_DOWNLOAD_QUALITY = 0.95;
+const PNG_SCALE = 2; // Higher quality for PNG
+export type BackgroundType = 'transparent' | 'solid';
const TRANSPARENT_RGBA = 'transparent';
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Dead constant declaration</b></div>
<div id="fix">
Constant `TRANSPARENT_RGBA` (line 30) is declared but no longer referenced
after the change at line 129 removed `color === TRANSPARENT_RGBA` check. This
is dead code introduced by the diff.
</div>
</div>
<small><i>Code Review Run #f5abf0</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
