rusackas commented on PR #35867: URL: https://github.com/apache/superset/pull/35867#issuecomment-4933559516
Pushed the three follow-ups, @CoderSxy. Added the bounds guard on `OptionSelector.reorder` so a stale or out-of-range index from a fast drag can't splice `undefined` in. `DndFilterSelect` now commits via `onChange` after the reorder... it was only doing `setValues`, so the new filter order was never actually persisting. And the stale drop-commit on the metric/adhoc paths: `moveLabel` now commits the freshly reordered array through `handleChange`, and the drop event is a no-op so it can't re-commit the pre-drag order behind it. Added committed-order tests that assert what reaches `onChange`, not just the rendered order. CI's running now. Thanks again for diagnosing the original swap-vs-reorder bug! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
