mikebridge opened a new pull request, #42014:
URL: https://github.com/apache/superset/pull/42014

   ### SUMMARY
   
   Restore `pre-commit run --all-files` on current `master` by addressing two 
latent Python failures:
   
   - narrow semantic-query filter and datetime types in the temporal-offset 
test so mypy can verify them
   - extract MCP destructive-SQL validation into a typed helper so 
`execute_sql` remains below the Ruff complexity threshold without changing 
behavior
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not applicable.
   
   ### TESTING INSTRUCTIONS
   
   ```bash
   source ~/venv/superset/bin/activate
   pytest -q tests/unit_tests/semantic_layers/mapper_test.py 
tests/unit_tests/mcp_service/sql_lab/tool/test_execute_sql.py
   pre-commit run --all-files
   ```
   
   Observed locally: 228 focused tests passed; the complete pre-commit suite 
passed.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to