villebro commented on issue #41854: URL: https://github.com/apache/superset/issues/41854#issuecomment-4966666954
@michael-s-molina if possible, I would still prefer to have the transport layer encoding decoupled from the actual codec implementation by having an explicit `isBinary` or `isBase64` flag on the REST API. In the future when we expose codecs as a contribution type, we may have arbitrary binary and non-binary codecs, and in that case we won't be able to infer the need for base64 encoding from the codec name alone. So before deciding on this design, I would still re-test the design by checking if the base64 inference logic still holds when the set of codecs is no longer defined in the host codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
