Abdulrehman-PIAIC80387 commented on PR #41994: URL: https://github.com/apache/superset/pull/41994#issuecomment-4989463794
Thanks @michael-s-molina — reduced scope to just the unambiguous cases: - `SET NULL` on pure audit trails: `logs.user_id`, `key_value.created_by_fk/changed_by_fk` - `CASCADE` on owner-junction tables: `favstar`, `user_attribute`, `tab_state`, `user_favorite_tag` Removed all user-owned artifacts you flagged (`saved_query`, `query`, `slices.last_saved_by_fk`, and the whole `AuditMixinNullable` change) — those need the SIP. Both user-reported errors on the issue are covered by this. Verified on Postgres, tests pass. Happy to hear further thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
