rusackas commented on PR #41975: URL: https://github.com/apache/superset/pull/41975#issuecomment-4997258645
Thanks for adding coverage for both URI forms, that addresses my earlier comment. Codeant's thread on `bigquery.py:731` is right though. `adjust_engine_params` writes the resolved schema into `url.database`, so once a query goes through `get_engine(catalog=..., schema=...)` with no project anywhere (ADC-only, `bigquery://`) but a schema set, `url.host` comes back empty and `project = url.host or url.database or None` picks up the dataset name instead. That'd send the wrong project to `bigquery.Client` for exactly the case this PR is trying to help. Worth a test that goes through `adjust_engine_params` with a schema and no project to catch this before it merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
