codeant-ai-for-open-source[bot] commented on code in PR #37516:
URL: https://github.com/apache/superset/pull/37516#discussion_r3601032499
##########
superset/commands/chart/warm_up_cache.py:
##########
@@ -96,12 +101,14 @@ def _warm_up_non_legacy_cache(self, chart: Slice) ->
tuple[Any, Any]:
query_context.force = True
command = ChartDataCommand(query_context)
command.validate()
- payload = command.run()
+ execution: ChartDataExecutionResult = command.execute(
+ ChartDataExecutionOptions(mode=ChartDataExecutionMode.CACHE_ONLY)
+ )
# Report the first error.
- for query_result in cast(list[dict[str, Any]], payload["queries"]):
- error = query_result.get("error")
- status = query_result.get("status")
+ for query_result in execution.queries:
+ error = query_result.payload.get("error")
+ status = query_result.payload.get("status")
Review Comment:
**Suggestion:** Add explicit type annotations for the newly introduced local
variables in the execution-results loop to satisfy the type-hint requirement
for relevant variables. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The modified Python code introduces two local variables, `error` and
`status`, without type annotations even though their types can be inferred and
annotated. This matches the type-hint rule for relevant variables in new or
changed code.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=24d5983b91754847b151284011ad9f1d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=24d5983b91754847b151284011ad9f1d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/chart/warm_up_cache.py
**Line:** 109:111
**Comment:**
*Custom Rule: Add explicit type annotations for the newly introduced
local variables in the execution-results loop to satisfy the type-hint
requirement for relevant variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=2d6fdac578fe49eebbb47e2528ae82b3f1d3d42edd5fcb96d3a658e1f47dbcd9&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=2d6fdac578fe49eebbb47e2528ae82b3f1d3d42edd5fcb96d3a658e1f47dbcd9&reaction=dislike'>๐</a>
##########
superset/charts/data/timing.py:
##########
@@ -0,0 +1,138 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import time
+from collections.abc import Callable, Iterator
+from contextlib import contextmanager
+from contextvars import ContextVar
+from dataclasses import dataclass, field
+from functools import wraps
+from typing import Literal, ParamSpec, TypeVar
+
+from flask import current_app, Response
+
+P = ParamSpec("P")
+R = TypeVar("R", bound=Response)
+
+ChartTimingPhase = Literal[
+ "context",
+ "authorize",
+ "query",
+ "client",
+ "serialize",
+ "enqueue",
+]
+
+_PHASE_NAMES: dict[ChartTimingPhase, str] = {
+ "context": "chart-context",
+ "authorize": "chart-authorize",
+ "query": "chart-query",
+ "client": "chart-client",
+ "serialize": "chart-serialize",
+ "enqueue": "chart-enqueue",
+}
+
+
+@dataclass
+class ChartRequestTiming:
+ """Request-local accumulator for fixed chart API phases."""
+
+ started_ns: int = field(default_factory=time.perf_counter_ns)
+ phases_ns: dict[ChartTimingPhase, int] = field(default_factory=dict)
+
+ def add(self, phase: ChartTimingPhase, duration_ns: int) -> None:
+ self.phases_ns[phase] = self.phases_ns.get(phase, 0) + max(0,
duration_ns)
+
+
+_request_timing: ContextVar[ChartRequestTiming | None] = ContextVar(
+ "chart_data_request_timing", default=None
+)
+
+
+@contextmanager
+def chart_timing_phase(phase: ChartTimingPhase) -> Iterator[None]:
+ """Measure one fixed chart API phase when request collection is active."""
+ timing = _request_timing.get()
+ if timing is None:
+ yield
+ return
+ if phase not in _PHASE_NAMES:
+ raise ValueError(f"Unknown chart timing phase: {phase}")
+ started_ns = time.perf_counter_ns()
+ try:
+ yield
+ finally:
+ timing.add(phase, time.perf_counter_ns() - started_ns)
+
+
+def chart_data_request_timing(func: Callable[P, R]) -> Callable[P, R]:
+ """Collect request timing and conditionally add a Server-Timing header."""
+
+ @wraps(func)
+ def wrapped(*args: P.args, **kwargs: P.kwargs) -> R:
+ timing = ChartRequestTiming()
+ token = _request_timing.set(timing)
+ response: R | None = None
+ try:
+ response = func(*args, **kwargs)
+ return response
+ finally:
+ total_ns = max(0, time.perf_counter_ns() - timing.started_ns)
+ try:
+ _emit_request_metrics(timing, total_ns)
+ if response is not None and
_should_add_server_timing(response):
+ response.headers["Server-Timing"] = _server_timing_value(
+ timing, total_ns
+ )
+ except Exception: # pylint: disable=broad-except
+ current_app.logger.exception("Unable to finalize chart request
timing")
+ finally:
+ _request_timing.reset(token)
+
+ return wrapped
+
+
+def _should_add_server_timing(response: Response) -> bool:
+ return bool(
+ current_app.config.get("CHART_DATA_INCLUDE_SERVER_TIMING")
+ and 200 <= response.status_code < 300
+ and response.mimetype == "application/json"
+ )
+
+
+def _server_timing_value(timing: ChartRequestTiming, total_ns: int) -> str:
+ values = [
+ f"{_PHASE_NAMES[phase]};dur={duration_ns / 1_000_000:.2f}"
+ for phase in _PHASE_NAMES
+ if (duration_ns := timing.phases_ns.get(phase)) is not None
+ ]
+ values.append(f"chart-total;dur={total_ns / 1_000_000:.2f}")
+ return ", ".join(values)
+
+
+def _emit_request_metrics(timing: ChartRequestTiming, total_ns: int) -> None:
+ try:
+ stats_logger = current_app.config.get("STATS_LOGGER")
Review Comment:
**Suggestion:** Add a concrete type annotation for this logger-like local
variable so the new code includes type hints for relevant variables.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is newly added Python code and the local variable is used as a
logger-like object but has no explicit type annotation. That fits the type-hint
requirement for relevant variables, so the suggestion is valid.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=79f75064f5f34cfc97161c7e15e1bb2a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=79f75064f5f34cfc97161c7e15e1bb2a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/charts/data/timing.py
**Line:** 130:130
**Comment:**
*Custom Rule: Add a concrete type annotation for this logger-like local
variable so the new code includes type hints for relevant variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=3fdf5ca2b1d93d8f2d2b69b7f0ddf74b16f3ebf021cffa965b06ff760ba757a9&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=3fdf5ca2b1d93d8f2d2b69b7f0ddf74b16f3ebf021cffa965b06ff760ba757a9&reaction=dislike'>๐</a>
##########
superset/charts/data/timing.py:
##########
@@ -0,0 +1,138 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+import time
+from collections.abc import Callable, Iterator
+from contextlib import contextmanager
+from contextvars import ContextVar
+from dataclasses import dataclass, field
+from functools import wraps
+from typing import Literal, ParamSpec, TypeVar
+
+from flask import current_app, Response
+
+P = ParamSpec("P")
+R = TypeVar("R", bound=Response)
+
+ChartTimingPhase = Literal[
+ "context",
+ "authorize",
+ "query",
+ "client",
+ "serialize",
+ "enqueue",
+]
+
+_PHASE_NAMES: dict[ChartTimingPhase, str] = {
+ "context": "chart-context",
+ "authorize": "chart-authorize",
+ "query": "chart-query",
+ "client": "chart-client",
+ "serialize": "chart-serialize",
+ "enqueue": "chart-enqueue",
+}
+
+
+@dataclass
+class ChartRequestTiming:
+ """Request-local accumulator for fixed chart API phases."""
+
+ started_ns: int = field(default_factory=time.perf_counter_ns)
+ phases_ns: dict[ChartTimingPhase, int] = field(default_factory=dict)
+
+ def add(self, phase: ChartTimingPhase, duration_ns: int) -> None:
+ self.phases_ns[phase] = self.phases_ns.get(phase, 0) + max(0,
duration_ns)
+
+
+_request_timing: ContextVar[ChartRequestTiming | None] = ContextVar(
+ "chart_data_request_timing", default=None
+)
+
+
+@contextmanager
+def chart_timing_phase(phase: ChartTimingPhase) -> Iterator[None]:
+ """Measure one fixed chart API phase when request collection is active."""
+ timing = _request_timing.get()
Review Comment:
**Suggestion:** Add an explicit local type annotation for this request
timing value to satisfy the type-hint requirement for relevant variables.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
The new Python code introduces a local variable that is inferable but not
explicitly annotated. Under the type-hint rule, this is a relevant variable
that can be annotated, so the suggestion identifies a real violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3a89fcaf38fc48dcb98dba0505831452&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3a89fcaf38fc48dcb98dba0505831452&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/charts/data/timing.py
**Line:** 70:70
**Comment:**
*Custom Rule: Add an explicit local type annotation for this request
timing value to satisfy the type-hint requirement for relevant variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=19599eb112b2244f851167f458956b3b885d641c48eb93d022331abc254f6ce9&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=19599eb112b2244f851167f458956b3b885d641c48eb93d022331abc254f6ce9&reaction=dislike'>๐</a>
##########
superset/models/helpers.py:
##########
@@ -1882,6 +1897,8 @@ def processing_time_offsets( # pylint:
disable=too-many-locals,too-many-stateme
join_keys = [col for col in df.columns if col not in metric_names]
for offset in query_object.time_offsets:
+ # Each offset must start from the original request state.
+ query_object_clone = copy.copy(query_object)
Review Comment:
**Suggestion:** Add an explicit variable type annotation for this cloned
query object to satisfy the type-hint requirement for newly introduced
variables. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is a newly added local variable in modified Python code and it can be
annotated with `QueryObject`; the rule requires type hints for relevant
variables that can be annotated, so the omission is a real violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=03d4f52dad0c4277847a8e8d772f789a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=03d4f52dad0c4277847a8e8d772f789a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/models/helpers.py
**Line:** 1900:1901
**Comment:**
*Custom Rule: Add an explicit variable type annotation for this cloned
query object to satisfy the type-hint requirement for newly introduced
variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=994140d39588564cef5a8f5e5e074c02d97d98a118638e3bfa179629d8ccb5a0&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=994140d39588564cef5a8f5e5e074c02d97d98a118638e3bfa179629d8ccb5a0&reaction=dislike'>๐</a>
##########
superset/models/helpers.py:
##########
@@ -4234,16 +4260,33 @@ def _create_join_condition(col_name: str, expr: Any) ->
Any:
"order_desc": True,
}
- result = self.query(prequery_obj)
- prequeries.append(result.query)
- dimensions = [
- c
- for c in result.df.columns
- if c not in metrics and c in groupby_series_columns
- ]
- top_groups = self._get_top_groups(
- result.df, dimensions, groupby_series_columns,
columns_by_name
- )
+ if defer_source_queries:
+ prequery = self.get_query_str_extended(
+ prequery_obj,
+ mutate=False,
+ defer_source_queries=True,
+ )
Review Comment:
**Suggestion:** Add a type annotation to this newly introduced local
variable so its expected structure is explicit and type-checkable. [custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This branch introduces a new local variable whose return type is known
(`QueryStringExtended`), so it should be annotated under the type-hint rule;
the existing code omits that annotation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=e4355cf9c14c4e91a6856bbbb5b3bdf1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=e4355cf9c14c4e91a6856bbbb5b3bdf1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/models/helpers.py
**Line:** 4263:4268
**Comment:**
*Custom Rule: Add a type annotation to this newly introduced local
variable so its expected structure is explicit and type-checkable.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=d022fca29773498715dab598ed0acbba0de49a80110f0655b932cb2e37bf493a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=d022fca29773498715dab598ed0acbba0de49a80110f0655b932cb2e37bf493a&reaction=dislike'>๐</a>
##########
superset/models/helpers.py:
##########
@@ -2102,27 +2119,33 @@ def processing_time_offsets( # pylint:
disable=too-many-locals,too-many-stateme
query_object_clone_dct["row_offset"] = 0
# Call the unified query method on the datasource
- result = self.query(query_object_clone_dct)
-
- queries.append(result.query)
- cache_keys.append(None)
+ with source_timing(SourceKind.TIME_OFFSET, SourceProvider.SQL):
+ result = self.query(query_object_clone_dct)
Review Comment:
**Suggestion:** Annotate this new local result variable with its expected
return type to comply with the rule requiring type hints in modified code.
[custom_rule]
**Severity Level:** Minor ๐งน
<details>
<summary><b>Why it matters? โญ </b></summary>
This is a newly introduced local variable in modified Python code, and it
can be annotated as `QueryResult`; the code currently omits that type hint,
matching the rule violation.
</details>
<details>
<summary><b>Rule source ๐ </b></summary>
.cursor/rules/dev-standard.mdc (line 28)
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8aec95cfee45461cad03f91f80c058f2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8aec95cfee45461cad03f91f80c058f2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/models/helpers.py
**Line:** 2122:2123
**Comment:**
*Custom Rule: Annotate this new local result variable with its expected
return type to comply with the rule requiring type hints in modified code.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=813156f5aeb64290d6d8d7e67c03c040f20c667109099873e6eb0e6280fe1f84&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=813156f5aeb64290d6d8d7e67c03c040f20c667109099873e6eb0e6280fe1f84&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
